Add Uppy integration #2059
Open
Add Uppy integration #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for putting this together, it's been on our list for a while, and due to be tackled in 2.2.0/3.1.0. I'll have to take some time to thoroughly test this with all aspects of Formie, but it's an amazing start at the very least. There's been a few workarounds to make File Upload fields accommodate this lack of feature set, and it's also something we'd want users to opt into. I'll put this on my list to review in detail. |
|
I've updated my fork with the changes I've made to ensure File Upload fields within Repeater fields get their Assets uploaded to the correct Row, using the recently added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in detail in #133, there is currently no out-of-the-box solution for web browsers to display already uploaded files in a native
<input type="file">field. This Pull Request aims to alleviate that issue by integrating Uppy into the File Upload JS, as well as adding a new Controller that will take care of the user's file submission and file deletion. The special file upload field template is also updated to reflect on the change by adding some extra information that Uppy requires in the HTMLdata-attributes.Known issues currently are:
AssetControllerTraitwas used as reference but I could not test it extensively past my own development environment.That aside, I would be more than happy to talk about the solution I've provided, and will gladly make any required changes.